Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avoidance): (TEMPORARY) steering factor for avoidance maneuver #1193

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

satoshi-ota
Copy link

@satoshi-ota satoshi-ota commented Mar 18, 2024

Description

Record avoidance start/finish time stamp by using steering factor.

  • start time: status = 100
  • end time status = 200

Time stamp is recorded only when the avoidance path straddles lane border line.

simplescreenrecorder-2024-03-19_19.10.23.mp4

Tests performed

start avoidance maneuver.

Screenshot from 2024-03-19 19-12-54

end avoidance maneuver.

Screenshot from 2024-03-19 19-13-32

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <[email protected]>
@TomohitoAndo
Copy link

TomohitoAndo commented Mar 22, 2024

I set the enable_rtc of avoidance to true and confirmed the status changed when the avoidance starts and ends.

avoidance-steering-factor.mp4

Start of the avoidance
image

End of the avoidance
image

Also, I confirmed that status didn't change to 100 or 200 when the avoidance was performed within the lane.

avoidance-steering-factor2.mp4

Copy link

@TomohitoAndo TomohitoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit 213c263 into beta/v0.19.1 Apr 8, 2024
16 of 17 checks passed
@satoshi-ota satoshi-ota deleted the feat/steering_factor_for_avoidance branch April 8, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants